Reduce startup overhead #2763
Merged
Reduce startup overhead #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentyi
force-pushed
the
brent/reduce_import_overhead
branch
from
07eb654 to
d32bfe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to reduce startup overhead!
For just printing the helptext, from
$ time ns-train --help,10.00s user 5.89s system 166% cpu 9.519 total2.75s user 1.62s system 156% cpu 2.797 totalThe biggest chunk of this was from making some less-used imports lazy. Some examples of things that mattered:
torchvisiontook 0.5~0.6 seconds to import. (most of which was extensions for the ConvNeXt model...)comet_mlrequired 0.3~0.4 seconds.diffusersrequired 0.4~0.5 seconds.open3drequired 0.4~0.5 seconds.(we should ideally do some of this profiling in the CI)
I also bumped to the faster
viserversion (from nerfstudio-project/viser#159) and cleaned up some CLI things, where we were creating unnecessary subparsers for deprecated config fields.